- Do have people experienced with the code reviewing the code of those less familiar. Effectiveness largely depends on experience and familiarity.
- Do allow people to review code on their own in quiet.
- Don’t review code in a meeting, it’s ineffective and a time waster.
- Do a two pass review, one to clean-up, a second for correctness.
- Do review your own code, you’ll find half the defects on your own.
- Do have two reviewers, it’s the most effective number.
- Do focus on correctness and maintainability, not on formatting and style.
- Do have a check list of things to check.
- Don’t forget to challenge assumptions that the developer made.
- Don’t forget the code reviews are a learning opportunity!
